ba8b5a67cb
Kill unused initialization code in arcfour.
Tim Cava
2013-07-09 06:39:50 +00:00
0e099fe064
Kill unused code in dcc_sdcc() and eliminate an unused pointer value warning from Coverity.
Tim Cava
2013-07-08 04:42:46 +00:00
b1e59bed9e
Convert uses of new_malloc/strcpy in end_vote() to m_strdup. While I'm here, don't cast what new_malloc returns.
Tim Cava
2013-07-07 09:28:11 +00:00
c76c962feb
Convert uses of new_malloc/strcpy in take_vote() to m_strdup. While I'm here, don't cast what new_malloc returns.
Tim Cava
2013-07-07 09:22:04 +00:00
e42c16a832
Convert uses of new_malloc/strcpy in take_acro() to m_strdup. While I'm here, don't cast what new_malloc returns.
Tim Cava
2013-07-07 09:17:02 +00:00
5ab9f87936
Simplify show_acros() by sending each line immediately, rather than buffering lines together.
Tim Cava
2013-07-07 08:51:25 +00:00
8a02a1946a
Simplify show_scores() by sending each line immediately, rather than buffering lines together. This also avoids a dereference before null check found by Coverity.
Tim Cava
2013-07-07 08:39:34 +00:00
114f6f52f0
Reorder the members of struct _srec to make type punning with Lists work.
Tim Cava
2013-07-03 03:06:44 +00:00
ed1ad22d70
Rewrite read_scores() with suggestions from caf. Failing to open the scores file no longer leaks memory, and a malformed record no longer adds an empty link to the global scores list.
Tim Cava
2013-07-02 14:42:36 +00:00
4ff0b8d2d5
Make sure setupterm() returns ERR before examining the status value.
Tim Cava
2013-07-01 01:23:18 +00:00
c464efa90e
Fix file descriptor leak in read_scores() found by Coverity.
Tim Cava
2013-06-28 07:34:06 +00:00
ee761e7f02
Skip malformed entries in abots.sav, which avoids two null dereferences found by Coverity.
Tim Cava
2013-06-28 05:22:20 +00:00
7a5448aa74
Don't make a copy of args, it goes unused. Remove the variable it was stored to. Found by Coverity.
Tim Cava
2013-06-26 13:09:01 +00:00
3812cf36a6
Don't bother storing what get_window_by_name() returns, it goes unused. Found by Coverity.
Tim Cava
2013-06-26 11:51:41 +00:00
b5574f3b23
Replace fprintf() of single fixed buffer with fputs().
Kevin Easton
2013-06-25 12:16:38 +00:00
8a04cbeba8
Don't pass the output of convert_output_format(FORMAT_DCC, ...) directly to sprintf() as a format string, because there could (and usually are!) '%' characters that will be interpreted by sprintf.
Kevin Easton
2013-06-23 14:36:32 +00:00
dd9de3dff0
Update (currently un-used) save_digraphs() function so that it compiles cleanly with -Werror=format-security.
Kevin Easton
2013-06-23 14:32:47 +00:00
c51810738e
Improve handling of one kind of malformed CDCC save file, where the pack description line doesn't contain a space. Found by Coverity.
Kevin Easton
2013-06-20 01:45:29 +00:00
882c3150e2
Fix open file leak in /LASTLOG, in situations like:
Kevin Easton
2013-06-18 12:55:32 +00:00
2fc84d5f93
Fix a file descriptor leak when connect() fails during a SOCKS4 proxy connection attempt.
Kevin Easton
2013-06-18 11:00:12 +00:00
b26e295137
Improve cryptit() fixes, suggested by caf.
Tim Cava
2013-06-17 08:00:37 +00:00
df8328c3a1
Fix out-of-bounds error in cryptit() found by Coverity.
Tim Cava
2013-06-16 14:40:52 +00:00
88172a9004
paused_topic should be the same size as help_topic_list.
Kevin Easton
2013-06-16 13:12:59 +00:00
ceb0492734
Cleanup save_formats() by removing unused function argument.
Kevin Easton
2013-06-16 12:21:03 +00:00
bad477f9dc
Fix off-by-one error in the check for s against FD_SETSIZE in add_socketread() and set_socketwrite(). This was found by Coverity.
Kevin Easton
2013-06-16 06:04:29 +00:00
6045b8fe91
Fix installhelp target on OpenBSD.
Kevin Easton
2013-05-22 11:56:20 +00:00
092d9789e0
Order the rfc1459[] array correctly.
Kevin Easton
2013-04-24 12:05:44 +00:00
73269ea887
Bail out of check_auto_reply() early if auto_str is NULL. This fixes a crash after /SETAR -.
Kevin Easton
2013-03-01 12:33:00 +00:00
17e3a91f03
Remove handling for the 484 numeric. It was intended for ircnet's 484 (ERR_RESTRICTED), to set user mode +r - however this does not appear to be necessary anymore. It was also buggy for several reasons: due to a change in set_server_flag() this has actually been setting mode +G; and 484 is ERR_ISCHANSERVICE on other ircds.
Kevin Easton
2013-02-25 12:22:54 +00:00
d7a0c781f8
Convert simple uses of alloca/strcpy to LOCAL_COPY.
Tim Cava
2013-02-24 07:32:59 +00:00
a7c93a3950
Remove a redundant call to alloca.
Tim Cava
2013-02-23 20:57:24 +00:00
e99861dbfb
Add /OBITS command showing obituaries for long-time BitchX friends.
Kevin Easton
2013-02-21 22:29:34 +00:00
5da6c807c2
Remove old reference to BitchX.com
Kevin Easton
2013-02-21 11:04:35 +00:00
29a3747534
Fix sequence point issue in arcfour (S[x] = --x; is undefined).
Kevin Easton
2013-02-16 13:32:00 +00:00
1390402af1
Fix abuses of the RESIZE() macro in array.c, of the form:
Kevin Easton
2013-02-16 08:11:07 +00:00
934d19aaa2
Some more minor BitchX.quit tidying.
Kevin Easton
2013-02-16 08:06:20 +00:00
6c7e32a97d
remove bx12-sasl.diff from main dir and remove patch reject -- im a noob
Dan Mashal
2013-02-07 23:43:53 -08:00
580a613555
Various cygwin fixes and europa plugin fix
Dan Mashal
2013-02-07 23:36:40 -08:00
da954a5c37
Apply patch from Dan Mashal (VICODAN) - Fix incorrect FSF address.
Kevin Easton
2013-01-17 12:55:55 +00:00
a1ec2113e9
Fix sort_scores in the acro plugin - pass the correct number of array entries to qsort() and properly reconstruct the list.
Kevin Easton
2013-01-04 10:11:32 +00:00
f51de3a170
Fix the timer callbacks in the acro plugin to use the correct function signature.
Kevin Easton
2013-01-04 09:03:12 +00:00
bf40ef7015
Use INSTALL_DATA instead of INSTALL to install the BitchX.hints file. This means it's not made executable.
Kevin Easton
2013-01-03 03:03:30 +00:00
84346beafa
Make 'toc' target a dependency of aim.so, so that parallel building works.
Kevin Easton
2013-01-03 02:57:39 +00:00
c3a2a39513
Don't strip plugins on install - it's no longer really necessary and helps in debugging to have the symbols.
Kevin Easton
2013-01-03 02:48:09 +00:00
2027f75969
Move inclusion of system headers in misc.c to top, which fixes building on recent Cygwin (including windows.h after the macros defined in modval.h causes the build to fail due to our 'load' macro). Reported by VICODAN.
Kevin Easton
2013-01-02 22:40:58 +00:00
87b806a563
Seeding from the 1.2 tree.
Dan Mashal
2013-01-01 03:00:55 -08:00
d8c87c4ded
Update README.md
Dan Mashal
2013-01-01 02:43:04 -08:00
cb1f51c9d2
Initial commit
Dan Mashal
2013-01-01 02:42:02 -08:00
754f1a19eb
Update installation instructions, including changes from cpet.
Kevin Easton
2012-12-31 13:27:29 +00:00
b2c9da8fef
Fix the AC_CHECK_PLUGIN_SUPPORT configure macro so that it matches FreeBSD-1.* instead of FreeBSD-1*, which fixes building with plugins on FreeBSD-10. Also a similar fix for the FreeBSD-2.* case.
Kevin Easton
2012-12-30 22:47:03 +00:00
1541299fa1
Merge infrastructure for SASL authentication support from flashback.
Kevin Easton
2012-12-30 02:22:56 +00:00
0d67cac5f7
Add a note about fixing QUITs with SSL connections.
Tim Cava
2012-10-21 01:36:23 +00:00
1e7c7edd1b
Use LOG_PUBLIC instead of LOG_MSG for PRIVMSGs sent to channels.
Kevin Easton
2012-10-19 12:25:25 +00:00
f7607baf45
Add tcl.c to source distribution (panasync gave his permission for this to be released).
Kevin Easton
2012-10-19 12:11:05 +00:00
416fcda578
Fix QUIT messages with SSL connections.
Tim Cava
2012-09-20 02:36:48 +00:00
c604db14e5
Add cp437 tool to contrib/ directory.
Kevin Easton
2012-07-26 07:21:20 +00:00
18721ef0f2
Respin configure for configure.in r208.
Kevin Easton
2012-06-17 23:30:20 +00:00
dd0c756cbc
Add .deb package build files from nyet.
Kevin Easton
2012-06-17 23:26:20 +00:00
69fd6e12c7
Change command used to install help files so that it ignores VCS directories.
Kevin Easton
2012-06-17 23:22:55 +00:00
904ad9edef
Update sites and mailing list addresses.
Kevin Easton
2012-06-13 14:59:20 +00:00
d22a4531d8
Update old email addresses in user-visible messages.
Kevin Easton
2012-06-13 12:34:32 +00:00
46cf14c0da
Fix the MKNU command, with suggestions from caf.
Tim Cava
2012-06-07 04:22:17 +00:00
3ed7f68d4e
Rename include/bitchx to include/options.h. This fixes building on case-insensitive filesystems like NTFS or HFS+, where it clashes with the BitchX binary.
Kevin Easton
2012-06-02 14:53:37 +00:00
252d1bf004
On systems that support it, supply the AI_ADDRCONFIG flag to getaddrinfo(). This means that we shouldn't try to connect using IPv6 if the local machine doesn't have an IPv6 address itself.
Kevin Easton
2012-06-02 11:38:37 +00:00
64605b326c
Respin configure for configure.in r201.
Kevin Easton
2012-05-31 12:43:57 +00:00
fa42be30ae
Change configure.in to enable SSL by default, if libssl is present. Can still be disabled with --without-ssl.
Kevin Easton
2012-05-31 12:40:26 +00:00
dd51b53e7d
AC_CHECK_LIB() doesn't work to check for Windows API functions due to calling conventions, so use AC_LINK_IFELSE() instead.
Kevin Easton
2012-05-30 12:26:44 +00:00
27c4333ef5
Respin configure and defs.h.in for configure.in r198.
Kevin Easton
2012-05-28 13:54:19 +00:00
d13eee6683
The Cygwin resolver library doesn't fill out the list of name servers in res_init() if /etc/resolv.conf doesn't exist, which is usual.
Kevin Easton
2012-05-28 13:52:18 +00:00
1c2581aea3
Respin configure for configure.in r196.
Kevin Easton
2012-05-27 04:43:40 +00:00
79625bf516
Define BIND_4_COMPAT everywhere (except OS X, who just _had_ to be different) and switch to using BIND4 macros (GETSHORT / GETLONG).
Kevin Easton
2012-05-27 04:42:09 +00:00
82f7a2ccf2
Use AC_LANG_SOURCE() around argument to AC_LINK_IFELSE(), this means that we get confdefs.h included in the test.
Kevin Easton
2012-05-27 04:26:36 +00:00
6947c0492d
Update configure for configure.in r193.
Kevin Easton
2012-05-24 13:03:57 +00:00
8a9917270c
Alter method of finding resolver library name, to hopefully work on OSX. Now uses AC_LINK_IFELSE() to link a program that calls res_mkquery(), after defining BIND_8_COMPAT / BIND_4_COMPAT as per misc.c.
Kevin Easton
2012-05-24 13:02:44 +00:00
241f3df842
Spin up new configure for configure.in r191.
Kevin Easton
2012-05-15 14:32:26 +00:00
5b7c84fb55
Rework res_mkquery test, adding test for __res_mkquery to fix problem on x86-64 platforms reported by snadge.
Kevin Easton
2012-05-15 14:31:05 +00:00
43f5288dd4
Update document to remove old supported platforms list and correct old information about vhosts.
Kevin Easton
2012-05-15 14:29:06 +00:00
ab7d59f1f6
Add a length sanity check - just in case there's an implementation out there that parses AF_UNIX addresses in getaddrinfo() or something.
Kevin Easton
2012-05-15 14:01:42 +00:00
ba365bfd54
Fix logic error that can result in a potential crash (when getaddrinfo() fails and res happened to be NULL).
Kevin Easton
2012-05-15 13:29:32 +00:00
9ec4f49540
Apply patch from snadge to set BIND_4_COMPAT on OpenBSD. This is similar to the existing BIND_8_COMPAT fix for OSX.
Kevin Easton
2012-05-15 13:16:11 +00:00
2f79061c0d
Partially back out r183, by removing -fPIC from Cygwin builds. It's unnecessary there and just creates a warning.
Kevin Easton
2012-05-15 12:52:25 +00:00
5b95a36896
Rebuilt for aclocal.m4 changes in r183.
Kevin Easton
2012-05-15 12:36:51 +00:00
e16b8197b0
Change message at end of "make install" to make vicodan happy.
Kevin Easton
2012-05-15 12:35:19 +00:00
4e53ace4f1
Use -fPIC for building plugins on NetBSD, OpenBSD, FreeBSD, BSDI and Cygwin. Required for plugins to work on x86-64.
Kevin Easton
2012-05-15 12:22:13 +00:00
26a62fe7fa
Rework the IPV6 verison of BX_ip_to_host() so that it works on BSD (used by $iptoname() scripting function).
Kevin Easton
2012-05-14 13:56:52 +00:00
f035eceb72
Pass the right socket address length to bind() in client connections with IPv6 enabled. This fixes an issue reported by packet, where IPv4 conections don't work on FreeBSD when the client is built with IPv6 support and you have a local hostname set (with /hostname, -H or IRCHOST).
Kevin Easton
2012-05-13 14:06:53 +00:00
35f0400e1f
Fix typo.
Kevin Easton
2012-05-11 22:00:16 +00:00
d029695841
Remove old devel files that shouldn't have been left lying around.
Kevin Easton
2012-05-11 12:47:01 +00:00
e27169c15e
Rebuild for configure.in r177.
Kevin Easton
2012-05-11 12:32:51 +00:00
0271799a4a
Remove check for Linux from IPv6 tests. Replace GLIBC version test with a generic link test for "native" IPv6.
Kevin Easton
2012-05-11 12:31:31 +00:00
5d788560a4
Choose the address length passed to connect() based on the address family. This fixes making IPv4 connections on BSD when the client is compiled with IPv6 enabled.
Kevin Easton
2012-05-11 12:22:03 +00:00
0219904860
Ensure that real errors from connect() (eg. EINVAL) are detected and acted on immmediately, even for nonblocking connects.
Kevin Easton
2012-05-11 12:03:10 +00:00
8e66eb6653
A few updated quit messages.
Kevin Easton
2012-05-10 12:47:51 +00:00
972b428e89
Create relative rather than absolute link to BitchX executable at install time.
Kevin Easton
2012-05-10 12:42:25 +00:00
68a84226de
Rebuild for configure.in r170.
Kevin Easton
2012-05-10 12:41:24 +00:00
c9fa7b0ce1
Remove unused sys/syslimits.h include.
Kevin Easton
2012-05-10 12:31:04 +00:00
eb964e1c52
Remove BitchX.spec and gtkBitchX.spec - these are obsolete now. A new BitchX.spec will be added later.
Kevin Easton
2012-05-10 12:22:22 +00:00
822522affa
Fix test so that sig.inc isn't built if sys_siglist, _sys_siglist or strsignal is available.
Kevin Easton
2012-05-10 09:16:25 +00:00
5d1953946e
Use the correct dependencies when checking for net/if.h, arpa/inet.h and resolv.h (fixes a nasty configure spew on FreeBSD, reported by flashback).
Kevin Easton
2012-05-10 09:12:27 +00:00
de771dac56
Simplify install target for translation files and scripts. No longer creates bxglobal.old backup of bxglobal file at install time.
Kevin Easton
2012-05-08 15:41:09 +00:00
Tim Cava