Commit Graph

  • 4118a120bc Don't truncate the password and salt passed to crypt() by the $crypt() scripting function - this allows alternate hashing methods to be selected if supported by the C library. Kevin Easton 2013-08-20 12:50:39 +00:00
  • 9207c838f9 Use strlcpy and strlcat, rather than strmcpy and strncat, in tcl_putdcc(). Tim Cava 2013-08-18 09:56:12 +00:00
  • 2fea73808f Improve the initial seeding of the randm() RNG. This is the RNG selected for $rand() when RANDOM_SOURCE is 1. Kevin Easton 2013-08-17 15:10:17 +00:00
  • 641565d4eb Strengthen the algorithm that generates a random cookie for /detach. This is a backwards-compatible change, no update to the scr-bx binary is necessary. Kevin Easton 2013-08-17 14:51:28 +00:00
  • 5582171286 Switch random_number() to always use the best entropy source for internal client purposes. The RANDOM_SOURCE setting now only affects the $rand() scripting function. Kevin Easton 2013-08-17 14:47:04 +00:00
  • d194069da9 Use strlcpy, rather than strmcpy, in expand_twiddle(). Tim Cava 2013-08-17 09:28:09 +00:00
  • b80425ce7d Use strlcpy, rather than strmcpy, in get_userhost(). Tim Cava 2013-08-17 09:18:11 +00:00
  • 94f99bfdbb Use strlcpy, rather than strmcpy, in make_channel(). Tim Cava 2013-08-17 09:11:04 +00:00
  • 41e52c7cf5 Use strlcpy, rather than strmcpy, in do_newuser(). Tim Cava 2013-08-17 09:07:32 +00:00
  • 0b32d978f8 Actually use strlcpy. Tim Cava 2013-08-17 07:31:03 +00:00
  • 9a36857761 Use strlcpy, rather than strmcpy, in new_dcc_message_transmit(). Tim Cava 2013-08-17 07:29:02 +00:00
  • ebd5398d89 Use strlcpy, rather than strmcpy, in create_timer_ref(). Tim Cava 2013-08-17 06:22:58 +00:00
  • cc8f50b187 Use strlcpy, rather than strmcpy, in ov_server(). Tim Cava 2013-08-17 06:16:00 +00:00
  • 44c4f2baf9 Use strlcpy, rather than strmcpy, in function_ftime(). Tim Cava 2013-08-17 06:05:22 +00:00
  • 86e3064d2c Use strlcpy, rather than strmcpy, in function_rot13(). Tim Cava 2013-08-17 06:03:32 +00:00
  • 23d1f6ad74 Use strlcpy, rather than strmcpy, in function_fsize(). Tim Cava 2013-08-17 06:02:08 +00:00
  • e095a1f373 Use strlcpy, rather than strmcpy, in function_fexist(). Tim Cava 2013-08-17 05:58:39 +00:00
  • 2caa8a2637 Use strlcpy, rather than strmcpy, in set_realname(). Tim Cava 2013-08-17 05:42:09 +00:00
  • 7af7913c98 Use strlcpy, rather than strmcpy, in tcl_putscr(). Tim Cava 2013-08-17 05:21:31 +00:00
  • 172bb8c409 Use strlcpy, rather than strmcpy, in tcl_putserv(). Tim Cava 2013-08-17 05:19:50 +00:00
  • 3c4acd0446 Use strlcpy, rather than strmcpy, in tcl_putloglev(). Tim Cava 2013-08-17 05:16:23 +00:00
  • 5b3d5bf285 Use strlcpy, rather than strmcpy, in tcl_putcmdlog(). Tim Cava 2013-08-17 05:14:29 +00:00
  • 905bceb348 Use strlcpy, rather than strmcpy, in tcl_putlog(). Tim Cava 2013-08-17 05:13:15 +00:00
  • 8a0d84b3ab Use strlcpy, rather than strmcpy, in status_windowspec(). Tim Cava 2013-08-17 05:06:38 +00:00
  • bcdf91f415 Use strlcpy, rather than strmcpy, in status_refnum(). Tim Cava 2013-08-17 05:04:20 +00:00
  • e8bca384b9 Use strlcpy, rather than strmcpy, in status_topic(). Tim Cava 2013-08-17 05:01:46 +00:00
  • adf7bc4b68 Use strlcpy, rather than strmcpy, in status_channel(). Tim Cava 2013-08-17 04:59:44 +00:00
  • d56010df9b Use strlcpy, rather than strmcpy, in status_umode(). Tim Cava 2013-08-17 04:54:42 +00:00
  • fdddcf99bf Use strlcpy, rather than strmcpy, in make_status(). Tim Cava 2013-08-17 04:47:19 +00:00
  • 89d82d7ae0 Use strlcpy, rather than strmcpy, in fix_status_buffer(). Tim Cava 2013-08-17 04:39:08 +00:00
  • 0b0dbf5cf7 Make the RANDOM_LOCAL_PORTS setting actually use a random port. Kevin Easton 2013-08-15 15:06:21 +00:00
  • 176be1cff2 Add the ability to bind listening sockets to addresses, and use this for the /detach IPC socket. Kevin Easton 2013-08-15 14:05:15 +00:00
  • a394019490 Use strlcpy, rather than strmcpy, in window_log(). Tim Cava 2013-08-15 10:55:09 +00:00
  • 674558ece4 Use strlcpy, rather than strmcpy, in delete_window(). Tim Cava 2013-08-15 10:46:09 +00:00
  • e4e8a1358a Use strlcpy, rather than strmcpy, in show_server_map(). Tim Cava 2013-08-15 10:41:00 +00:00
  • 72cf367e45 Use strlcpy, rather than strmcpy, in accept_server_nickname(). Tim Cava 2013-08-15 10:35:43 +00:00
  • 68c3df7c6c Use strlcpy, rather than strmcpy, in set_server_nickname(). Tim Cava 2013-08-15 10:28:56 +00:00
  • 337dfe0d06 Don't copy into a passwd struct returned by getpwuid(). Tim Cava 2013-08-15 09:18:14 +00:00
  • 15c5f518fd Make the port passed to qbx's query_q_server() an unsigned short, which eliminates a warning. Tim Cava 2013-08-14 23:18:07 +00:00
  • bc485f95a8 Possum's llist uses memcpy, so include string.h and eliminate a warning. Tim Cava 2013-08-14 22:32:48 +00:00
  • a6f8021cd9 Fix a couple of compiler warnings in irc.c - two places where the address of an array was tested (always not-NULL) and one unused variable (first_time in io()). Kevin Easton 2013-08-14 14:39:24 +00:00
  • 1cfaf1349c Remove XLINK CTCP reply handler - it's not used for the botlink functionality. Kevin Easton 2013-08-14 13:34:04 +00:00
  • 4a25f5462f Simplify code that produces realname from gecos, replace strmcat() with strlcat(). Kevin Easton 2013-08-14 09:32:33 +00:00
  • 74f8a720c4 Use strchr, rather than index, which is a legacy function. From caf. Tim Cava 2013-08-14 07:22:32 +00:00
  • c0bc9294cd Use strlcpy, rather than strmcpy, in parse_args(). Tim Cava 2013-08-14 07:01:30 +00:00
  • b1d55bce82 Use memcpy, rather than strmcpy or strlcpy, in parse_command(). Suggested by caf. Tim Cava 2013-08-14 04:15:09 +00:00
  • 0460b22bb0 Use strlcpy, rather than strmcpy, in realname_cmd(). Tim Cava 2013-08-12 10:57:52 +00:00
  • 18142f0abe Use strlcpy, rather than strmcpy, in set_username(). Tim Cava 2013-08-12 10:37:10 +00:00
  • 44e59337ee Include the size of hostname, nickname, realname, userhost and username in their forward declarations. Tim Cava 2013-08-12 10:36:14 +00:00
  • 338a8ecd4c Remove unnecessary declarations in term.c for wserv builds. Kevin Easton 2013-08-12 09:40:59 +00:00
  • ca7f9c6b86 Use memcmp, rather than strncmp, in wavplay's validate_wav_header(), and avoid warnings about mismatched signedness. Tim Cava 2013-08-11 08:20:37 +00:00
  • c7cefb1c05 Don't look beyond the end of a cparse format if it ends with % or $. Kevin Easton 2013-08-10 15:59:04 +00:00
  • 9e0ba0a573 Pass correct buffer size to fgets(). Kevin Easton 2013-08-10 03:54:48 +00:00
  • 975bc2bc57 Don't compare an array to NULL, but check that the first character isn't NULL. Found by Coverity. Tim Cava 2013-08-09 07:30:54 +00:00
  • 6691732900 Make add_socketread() close the new socket if it can't be added to the socket manager because it exceeds FD_SETSIZE. Kevin Easton 2013-08-07 23:03:45 +00:00
  • 718e53d6f0 Refactor fserv's make_temp_list(), with help from caf, and use mkstemp() instead of tmpnam(), which is dangerous. Found by Coverity. Tim Cava 2013-08-07 01:00:11 +00:00
  • 16fac903e9 Reverse the last commit, which accidentally included generated files. Tim Cava 2013-08-07 00:56:16 +00:00
  • 1ead56a251 Refactor fserv's make_temp_list(), with help from caf, and use mkstemp() instead of tmpnam(), which is dangerous. Found by Coverity. Tim Cava 2013-08-07 00:50:43 +00:00
  • c85ca721e3 strmcpy() does include the null terminator in the maximum number of bytes to be written, so use sizeof - 1 instead of sizeof. Kevin Easton 2013-08-01 14:47:12 +00:00
  • 565621d070 Use strmcpy, instead of strcpy, to initialize FSstr. Fixes a potential buffer overflow found by Coverity. Tim Cava 2013-07-31 09:28:46 +00:00
  • aefa6e71f4 Kill an unnecessary LOCAL_COPY() in fserv's print_mp3(). Tim Cava 2013-07-31 07:39:13 +00:00
  • 94e04ff631 Remove a small amount of dead code found by Coverity. Tim Cava 2013-07-31 07:28:45 +00:00
  • b0fa3c55e6 Fix the for loop in cav_away(). Tim Cava 2013-07-31 07:15:29 +00:00
  • 4057523aef Don't bother storing what find_in_list() returns, it goes unused. Found by Coverity. Tim Cava 2013-07-31 05:50:22 +00:00
  • d68a196b8a Mention fixes to commands in the banlist.c cleanup. Tim Cava 2013-07-31 05:40:44 +00:00
  • 92012cccd1 Cleanup banlist.c and fix a few bugs, with suggestions from caf. Tim Cava 2013-07-17 14:17:29 +00:00
  • 49a7117900 Including dcc.h in window.c is unnecessary. Tim Cava 2013-07-15 06:21:26 +00:00
  • 73bf008b9f Remove a duplicate include of dcc.h. Tim Cava 2013-07-15 06:20:49 +00:00
  • 2d0c2ac415 Including dcc.h in screen.c is unnecessary. Tim Cava 2013-07-15 06:19:53 +00:00
  • be47d08d53 Including dcc.h in exec.c is unnecessary. Tim Cava 2013-07-15 06:19:02 +00:00
  • 4309055cf7 Including dcc.h in commands2.c is unnecessary. Tim Cava 2013-07-15 06:02:23 +00:00
  • b786c75e7a Include string.h in arcfour's MD5 implementation, since it uses memset(). Tim Cava 2013-07-15 04:23:40 +00:00
  • 6ae6edc0fb Make the definition of Tgetstr() use the value of y, when terminfo is available, which quiets an unused variable warning. Tim Cava 2013-07-15 04:13:52 +00:00
  • 2d80cbb680 Restore this variable, as it's used when terminfo isn't available. Tim Cava 2013-07-15 03:48:43 +00:00
  • 3b509dfa52 Kill an unused variable in term_init(). Tim Cava 2013-07-15 03:17:49 +00:00
  • 84a87ca7ec Add socklen_t typedef for very old systems that don't provide it. Kevin Easton 2013-07-15 01:29:43 +00:00
  • 9378704c39 Improve the list_channels() function so that it behaves correctly when connected to multiple servers. Kevin Easton 2013-07-14 14:01:20 +00:00
  • 7d9ffbe792 Add Changelog entry for socklen_t change. Kevin Easton 2013-07-14 13:33:09 +00:00
  • e915462aef Change a & to && in BX_do_compress_modes() to squash a warning. Should be no behavioural change. Kevin Easton 2013-07-14 13:25:22 +00:00
  • 0450875ab5 Remove two unnecessary includes from alias.c. Tim Cava 2013-07-14 05:26:51 +00:00
  • 37dcaad1ae Make the addrlen passed to connect() in connect_by_number() a socklen_t. Tim Cava 2013-07-14 04:16:13 +00:00
  • e070369079 Make the namelen passed to getsockname() a socklen_t everywhere. Tim Cava 2013-07-14 03:26:00 +00:00
  • 80cfa9c5d8 Make the namelen passed to getpeername() a socklen_t everywhere. Tim Cava 2013-07-14 03:18:47 +00:00
  • 27ed98a03d Make the addrlen passed to my_accept() a socklen_t everywhere. Tim Cava 2013-07-14 03:09:16 +00:00
  • a3b938dfd5 Make the addrlen argument to my_accept() a socklen_t. Tim Cava 2013-07-14 02:59:11 +00:00
  • 2235c029bb Update Changelog for sys/termios -> termios fix. Kevin Easton 2013-07-14 02:03:44 +00:00
  • cc0b75f2dd Include <termios.h> in preference to <sys/termios.h>. Kevin Easton 2013-07-14 02:01:59 +00:00
  • ce86c78a21 Respin configure and defs.h.in for configure.in r273. Kevin Easton 2013-07-14 00:57:29 +00:00
  • 4673c6ff01 Add configure check for <termios.h>. Kevin Easton 2013-07-14 00:55:35 +00:00
  • 791c49986e Remove unnecessary termios.h includes. Kevin Easton 2013-07-14 00:51:58 +00:00
  • d2b9d769e8 Respin configure and defs.h.in for configure.in r270. Kevin Easton 2013-07-14 00:24:05 +00:00
  • f4d7123ad6 Add configure check for socklen_t. Kevin Easton 2013-07-14 00:14:24 +00:00
  • b4cd944bef The third argument to accept() should be a socklen_t. Tim Cava 2013-07-13 22:21:32 +00:00
  • 64779fd515 nap:naplink_handlelink() The third argument to accept() should be a socklen_t. Tim Cava 2013-07-13 21:58:15 +00:00
  • b5f835e8fc identd:identd_handler() The third argument to accept() should be a socklen_t. Tim Cava 2013-07-13 21:57:31 +00:00
  • 76528c6f38 arcfour:start_dcc_chat() The third argument to accept() should be a socklen_t. Tim Cava 2013-07-13 21:53:24 +00:00
  • d6393b8248 acro plugin: Use correct module name when registering command. Kevin Easton 2013-07-10 13:33:43 +00:00
  • b1de392172 acro plugin: Don't sort scores when saving to file. This was losing the head of the list, and it's not necessary anyway. Kevin Easton 2013-07-10 12:57:06 +00:00
  • ee35df3a41 Don't seed arcfour with uninitialized stack values when urandom can't be opened, but fail instead. Fixes using uninitialized value warnings from Coverity. Tim Cava 2013-07-09 07:06:43 +00:00
  • e39eddbc04 Oops. Remove init_schat()'s forward declaration. Tim Cava 2013-07-09 06:54:57 +00:00