philippelh/bitchx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
356 Commits 2 Branches 0 Tags
717d2e88b7332d3367a10d5d3ef39d9426f3edfe
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Tim Cava 07c6a61fed Use strlcpy, rather than strmcpy, in extract(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@375 13b04d17-f746-0410-82c6-800466cd88b0
 2013-09-21 05:12:43 +00:00
Tim Cava d01233f559 Use strlcpy, rather than strmcpy, in extract2(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@374 13b04d17-f746-0410-82c6-800466cd88b0
 2013-09-21 05:11:07 +00:00
Tim Cava 21612025eb Use strlcpy and strlcat, rather than strmcpy and strmcat, in decrypt_msg(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@373 13b04d17-f746-0410-82c6-800466cd88b0
 2013-09-18 23:41:46 +00:00
Tim Cava ea5aa01f87 Use strlcpy, rather than strmcpy, in cluster(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@372 13b04d17-f746-0410-82c6-800466cd88b0
 2013-09-18 23:28:07 +00:00
Tim Cava 6afd2d4a87 Use strlcpy, rather than strmcpy, in Tcl_GetKeyedListField(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@371 13b04d17-f746-0410-82c6-800466cd88b0
 2013-09-18 23:17:23 +00:00
Tim Cava c907a548e0 Use strlcpy, rather than strmcpy, in Tcl_GetKeyedListKeys(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@370 13b04d17-f746-0410-82c6-800466cd88b0
 2013-09-18 23:16:12 +00:00
Tim Cava 4de9626a99 Use strlcpy, rather than strmcpy, in set_input_heb(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@369 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-26 08:06:36 +00:00
Tim Cava fafd888528 Cleanup rename_file() a little bit. Use strlcpy, rather than strmcpy. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@368 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-26 08:04:21 +00:00
Tim Cava c13b00be0c Use strlcpy, rather than strmcpy, in set_input(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@367 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-23 05:37:03 +00:00
Tim Cava 4ba3f45a89 Cleanup check_mode_lock() a little bit. Use strlcat, rather than strcat. 
Prefer m_strdup over malloc_strcpy.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@366 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-23 04:49:54 +00:00
Tim Cava 56f5eceb26 Don't compare an array (cx_function) against NULL. Don't bother checking 
whether a context is empty, since the result is the same.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@365 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-23 02:55:27 +00:00
Tim Cava ceada1fac4 Use strlcpy, rather than strmcpy, in split_CTCP(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@364 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-21 05:57:50 +00:00
Tim Cava 1524033b3f Use strlcpy and strlcat, rather than strmcpy, strmcat, and strcpy, in 
do_notice_ctcp().


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@363 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-21 05:53:18 +00:00
Tim Cava 3808071ba6 Use strlcpy and strlcat, rather than strmcpy, strmcat, and strcpy, in 
do_ctcp().


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@362 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-21 05:46:02 +00:00
Tim Cava 9207c838f9 Use strlcpy and strlcat, rather than strmcpy and strncat, in tcl_putdcc(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@360 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-18 09:56:12 +00:00
Tim Cava d194069da9 Use strlcpy, rather than strmcpy, in expand_twiddle(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@356 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 09:28:09 +00:00
Tim Cava b80425ce7d Use strlcpy, rather than strmcpy, in get_userhost(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@355 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 09:18:11 +00:00
Tim Cava 94f99bfdbb Use strlcpy, rather than strmcpy, in make_channel(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@354 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 09:11:04 +00:00
Tim Cava 41e52c7cf5 Use strlcpy, rather than strmcpy, in do_newuser(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@353 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 09:07:32 +00:00
Tim Cava 0b32d978f8 Actually use strlcpy. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@352 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 07:31:03 +00:00
Tim Cava 9a36857761 Use strlcpy, rather than strmcpy, in new_dcc_message_transmit(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@351 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 07:29:02 +00:00
Tim Cava ebd5398d89 Use strlcpy, rather than strmcpy, in create_timer_ref(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@350 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 06:22:58 +00:00
Tim Cava cc8f50b187 Use strlcpy, rather than strmcpy, in ov_server(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@349 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 06:16:00 +00:00
Tim Cava 44c4f2baf9 Use strlcpy, rather than strmcpy, in function_ftime(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@348 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 06:05:22 +00:00
Tim Cava 86e3064d2c Use strlcpy, rather than strmcpy, in function_rot13(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@347 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 06:03:32 +00:00
Tim Cava 23d1f6ad74 Use strlcpy, rather than strmcpy, in function_fsize(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@346 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 06:02:08 +00:00
Tim Cava e095a1f373 Use strlcpy, rather than strmcpy, in function_fexist(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@345 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 05:58:39 +00:00
Tim Cava 2caa8a2637 Use strlcpy, rather than strmcpy, in set_realname(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@344 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 05:42:09 +00:00
Tim Cava 7af7913c98 Use strlcpy, rather than strmcpy, in tcl_putscr(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@343 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 05:21:31 +00:00
Tim Cava 172bb8c409 Use strlcpy, rather than strmcpy, in tcl_putserv(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@342 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 05:19:50 +00:00
Tim Cava 3c4acd0446 Use strlcpy, rather than strmcpy, in tcl_putloglev(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@341 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 05:16:23 +00:00
Tim Cava 5b3d5bf285 Use strlcpy, rather than strmcpy, in tcl_putcmdlog(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@340 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 05:14:29 +00:00
Tim Cava 905bceb348 Use strlcpy, rather than strmcpy, in tcl_putlog(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@339 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 05:13:15 +00:00
Tim Cava 8a0d84b3ab Use strlcpy, rather than strmcpy, in status_windowspec(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@338 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 05:06:38 +00:00
Tim Cava bcdf91f415 Use strlcpy, rather than strmcpy, in status_refnum(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@337 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 05:04:20 +00:00
Tim Cava e8bca384b9 Use strlcpy, rather than strmcpy, in status_topic(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@336 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 05:01:46 +00:00
Tim Cava adf7bc4b68 Use strlcpy, rather than strmcpy, in status_channel(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@335 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 04:59:44 +00:00
Tim Cava d56010df9b Use strlcpy, rather than strmcpy, in status_umode(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@334 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 04:54:42 +00:00
Tim Cava fdddcf99bf Use strlcpy, rather than strmcpy, in make_status(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@333 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 04:47:19 +00:00
Tim Cava 89d82d7ae0 Use strlcpy, rather than strmcpy, in fix_status_buffer(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@332 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-17 04:39:08 +00:00
Tim Cava a394019490 Use strlcpy, rather than strmcpy, in window_log(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@329 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-15 10:55:09 +00:00
Tim Cava 674558ece4 Use strlcpy, rather than strmcpy, in delete_window(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@328 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-15 10:46:09 +00:00
Tim Cava e4e8a1358a Use strlcpy, rather than strmcpy, in show_server_map(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@327 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-15 10:41:00 +00:00
Tim Cava 72cf367e45 Use strlcpy, rather than strmcpy, in accept_server_nickname(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@326 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-15 10:35:43 +00:00
Tim Cava 68c3df7c6c Use strlcpy, rather than strmcpy, in set_server_nickname(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@325 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-15 10:28:56 +00:00
Tim Cava 337dfe0d06 Don't copy into a passwd struct returned by getpwuid(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@324 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-15 09:18:14 +00:00
Tim Cava 15c5f518fd Make the port passed to qbx's query_q_server() an unsigned short, 
which eliminates a warning.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@323 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-14 23:18:07 +00:00
Tim Cava bc485f95a8 Possum's llist uses memcpy, so include string.h and eliminate a warning. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@322 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-14 22:32:48 +00:00
Tim Cava 74f8a720c4 Use strchr, rather than index, which is a legacy function. From caf. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@318 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-14 07:22:32 +00:00
Tim Cava c0bc9294cd Use strlcpy, rather than strmcpy, in parse_args(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@317 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-14 07:01:30 +00:00
Tim Cava b1d55bce82 Use memcpy, rather than strmcpy or strlcpy, in parse_command(). Suggested 
by caf.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@316 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-14 04:15:09 +00:00
Tim Cava 0460b22bb0 Use strlcpy, rather than strmcpy, in realname_cmd(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@315 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-12 10:57:52 +00:00
Tim Cava 18142f0abe Use strlcpy, rather than strmcpy, in set_username(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@314 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-12 10:37:10 +00:00
Tim Cava 44e59337ee Include the size of hostname, nickname, realname, userhost and username 
in their forward declarations.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@313 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-12 10:36:14 +00:00
Tim Cava ca7f9c6b86 Use memcmp, rather than strncmp, in wavplay's validate_wav_header(), 
and avoid warnings about mismatched signedness.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@311 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-11 08:20:37 +00:00
Tim Cava 975bc2bc57 Don't compare an array to NULL, but check that the first character isn't 
NULL. Found by Coverity.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@308 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-09 07:30:54 +00:00
Tim Cava 718e53d6f0 Refactor fserv's make_temp_list(), with help from caf, and use mkstemp() 
instead of tmpnam(), which is dangerous. Found by Coverity.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@306 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-07 01:00:11 +00:00
Tim Cava 16fac903e9 Reverse the last commit, which accidentally included generated files. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@305 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-07 00:56:16 +00:00
Tim Cava 1ead56a251 Refactor fserv's make_temp_list(), with help from caf, and use mkstemp() 
instead of tmpnam(), which is dangerous. Found by Coverity.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@304 13b04d17-f746-0410-82c6-800466cd88b0
 2013-08-07 00:50:43 +00:00
Tim Cava 565621d070 Use strmcpy, instead of strcpy, to initialize FSstr. Fixes a potential buffer overflow found by Coverity. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@302 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-31 09:28:46 +00:00
Tim Cava aefa6e71f4 Kill an unnecessary LOCAL_COPY() in fserv's print_mp3(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@301 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-31 07:39:13 +00:00
Tim Cava 94e04ff631 Remove a small amount of dead code found by Coverity. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@300 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-31 07:28:45 +00:00
Tim Cava b0fa3c55e6 Fix the for loop in cav_away(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@299 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-31 07:15:29 +00:00
Tim Cava 4057523aef Don't bother storing what find_in_list() returns, it goes unused. Found by Coverity. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@298 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-31 05:50:22 +00:00
Tim Cava d68a196b8a Mention fixes to commands in the banlist.c cleanup. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@297 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-31 05:40:44 +00:00
Tim Cava 92012cccd1 Cleanup banlist.c and fix a few bugs, with suggestions from caf. 
* Restore from_server in doop() when prepare_command() fails
* Make /bans &channel work
* Make /unban #channel #number work (caf)


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@296 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-17 14:17:29 +00:00
Tim Cava 49a7117900 Including dcc.h in window.c is unnecessary. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@295 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-15 06:21:26 +00:00
Tim Cava 73bf008b9f Remove a duplicate include of dcc.h. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@294 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-15 06:20:49 +00:00
Tim Cava 2d0c2ac415 Including dcc.h in screen.c is unnecessary. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@293 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-15 06:19:53 +00:00
Tim Cava be47d08d53 Including dcc.h in exec.c is unnecessary. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@292 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-15 06:19:02 +00:00
Tim Cava 4309055cf7 Including dcc.h in commands2.c is unnecessary. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@291 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-15 06:02:23 +00:00
Tim Cava b786c75e7a Include string.h in arcfour's MD5 implementation, since it uses memset(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@290 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-15 04:23:40 +00:00
Tim Cava 6ae6edc0fb Make the definition of Tgetstr() use the value of y, when terminfo is 
available, which quiets an unused variable warning.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@289 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-15 04:13:52 +00:00
Tim Cava 2d80cbb680 Restore this variable, as it's used when terminfo isn't available. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@288 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-15 03:48:43 +00:00
Tim Cava 3b509dfa52 Kill an unused variable in term_init(). 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@287 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-15 03:17:49 +00:00
Tim Cava 0450875ab5 Remove two unnecessary includes from alias.c. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@282 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-14 05:26:51 +00:00
Tim Cava 37dcaad1ae Make the addrlen passed to connect() in connect_by_number() a socklen_t. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@281 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-14 04:16:13 +00:00
Tim Cava e070369079 Make the namelen passed to getsockname() a socklen_t everywhere. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@280 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-14 03:26:00 +00:00
Tim Cava 80cfa9c5d8 Make the namelen passed to getpeername() a socklen_t everywhere. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@279 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-14 03:18:47 +00:00
Tim Cava 27ed98a03d Make the addrlen passed to my_accept() a socklen_t everywhere. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@278 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-14 03:09:16 +00:00
Tim Cava a3b938dfd5 Make the addrlen argument to my_accept() a socklen_t. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@277 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-14 02:59:11 +00:00
Tim Cava b4cd944bef The third argument to accept() should be a socklen_t. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@269 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-13 22:21:32 +00:00
Tim Cava 64779fd515 nap:naplink_handlelink() The third argument to accept() should be a 
socklen_t.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@268 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-13 21:58:15 +00:00
Tim Cava b5f835e8fc identd:identd_handler() The third argument to accept() should be a 
socklen_t.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@267 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-13 21:57:31 +00:00
Tim Cava 76528c6f38 arcfour:start_dcc_chat() The third argument to accept() should be a 
socklen_t.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@266 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-13 21:53:24 +00:00
Tim Cava ee35df3a41 Don't seed arcfour with uninitialized stack values when urandom can't be 
opened, but fail instead. Fixes using uninitialized value warnings from
Coverity.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@263 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-09 07:06:43 +00:00
Tim Cava e39eddbc04 Oops. Remove init_schat()'s forward declaration. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@262 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-09 06:54:57 +00:00
Tim Cava ba8b5a67cb Kill unused initialization code in arcfour. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@261 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-09 06:39:50 +00:00
Tim Cava 0e099fe064 Kill unused code in dcc_sdcc() and eliminate an unused pointer value 
warning from Coverity.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@260 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-08 04:42:46 +00:00
Tim Cava b1e59bed9e Convert uses of new_malloc/strcpy in end_vote() to m_strdup. While I'm 
here, don't cast what new_malloc returns.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@259 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-07 09:28:11 +00:00
Tim Cava c76c962feb Convert uses of new_malloc/strcpy in take_vote() to m_strdup. While 
I'm here, don't cast what new_malloc returns.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@258 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-07 09:22:04 +00:00
Tim Cava e42c16a832 Convert uses of new_malloc/strcpy in take_acro() to m_strdup. While 
I'm here, don't cast what new_malloc returns.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@257 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-07 09:17:02 +00:00
Tim Cava 5ab9f87936 Simplify show_acros() by sending each line immediately, rather than 
buffering lines together.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@256 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-07 08:51:25 +00:00
Tim Cava 8a02a1946a Simplify show_scores() by sending each line immediately, rather than 
buffering lines together. This also avoids a dereference before null
check found by Coverity.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@255 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-07 08:39:34 +00:00
Tim Cava 114f6f52f0 Reorder the members of struct _srec to make type punning with 
Lists work.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@254 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-03 03:06:44 +00:00
Tim Cava ed1ad22d70 Rewrite read_scores() with suggestions from caf. Failing to open the scores file no longer leaks memory, and a malformed record no longer adds an empty link to the global scores list. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@253 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-02 14:42:36 +00:00
Tim Cava 4ff0b8d2d5 Make sure setupterm() returns ERR before examining the status value. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@252 13b04d17-f746-0410-82c6-800466cd88b0
 2013-07-01 01:23:18 +00:00
Tim Cava c464efa90e Fix file descriptor leak in read_scores() found by Coverity. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@251 13b04d17-f746-0410-82c6-800466cd88b0
 2013-06-28 07:34:06 +00:00
Tim Cava ee761e7f02 Skip malformed entries in abots.sav, which avoids two null dereferences found by Coverity. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@250 13b04d17-f746-0410-82c6-800466cd88b0
 2013-06-28 05:22:20 +00:00
Tim Cava 7a5448aa74 Don't make a copy of args, it goes unused. Remove the variable it was stored to. Found by Coverity. 
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@249 13b04d17-f746-0410-82c6-800466cd88b0
 2013-06-26 13:09:01 +00:00