philippelh/bitchx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Order the rfc1459[] array correctly.

Browse Source 
This is a longstanding bug - it's also present in EPIC4 and EPIC5 so it's
probably been in BitchX since the beginning.  The bug has been latent until
the AUTHENTICATE and CAP commands were added, which perturbed the binary
search so that the client didn't see invite messages properly.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@235 13b04d17-f746-0410-82c6-800466cd88b0
This commit is contained in:
Kevin Easton
2013-04-24 12:05:44 +00:00
parent 73269ea887
commit 092d9789e0
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Changelog
View File

@@ -1,5 +1,7 @@
[Changes 1.2c01] [Changes 1.2c01]
* Fix longstanding bug with ordering of rfc1459[] array. (caf)
* Fix crash after /SETAR -, reported by riderplus. (caf) * Fix crash after /SETAR -, reported by riderplus. (caf)
* Remove special handling of 484 numeric, which is no longer needed and * Remove special handling of 484 numeric, which is no longer needed and

4
source/parse.c
View File

@@ -1831,8 +1831,8 @@ protocol_command rfc1459[] = {
{ "CONNECT", NULL, NULL, 0, 0, 0}, { "CONNECT", NULL, NULL, 0, 0, 0},
{ "ERROR", p_error, NULL, 0, 0, 0}, { "ERROR", p_error, NULL, 0, 0, 0},
{ "ERROR:", p_error, NULL, 0, 0, 0}, { "ERROR:", p_error, NULL, 0, 0, 0},
{ "INVITE", p_invite, NULL, 0, 0, 0},
{ "INFO", NULL, NULL, 0, 0, 0}, { "INFO", NULL, NULL, 0, 0, 0},
{ "INVITE", p_invite, NULL, 0, 0, 0},
{ "ISON", NULL, NULL, PROTO_NOQUOTE, 0, 0}, { "ISON", NULL, NULL, PROTO_NOQUOTE, 0, 0},
{ "JOIN", p_channel, NULL, PROTO_DEPREC, 0, 0}, { "JOIN", p_channel, NULL, PROTO_DEPREC, 0, 0},
{ "KICK", p_kick, NULL, 0, 0, 0}, { "KICK", p_kick, NULL, 0, 0, 0},
@@ -1859,8 +1859,8 @@ protocol_command rfc1459[] = {
{ "STATS", NULL, NULL, 0, 0, 0}, { "STATS", NULL, NULL, 0, 0, 0},
{ "SUMMON", NULL, NULL, 0, 0, 0}, { "SUMMON", NULL, NULL, 0, 0, 0},
{ "TIME", NULL, NULL, 0, 0, 0}, { "TIME", NULL, NULL, 0, 0, 0},
{ "TRACE", NULL, NULL, 0, 0, 0},
{ "TOPIC", p_topic, NULL, 0, 0, 0}, { "TOPIC", p_topic, NULL, 0, 0, 0},
{ "TRACE", NULL, NULL, 0, 0, 0},
{ "USER", NULL, NULL, 0, 0, 0}, { "USER", NULL, NULL, 0, 0, 0},
{ "USERHOST", NULL, NULL, PROTO_NOQUOTE, 0, 0}, { "USERHOST", NULL, NULL, PROTO_NOQUOTE, 0, 0},
{ "USERS", NULL, NULL, 0, 0, 0}, { "USERS", NULL, NULL, 0, 0, 0},