From 092d9789e0a955e3c8b1aedf11cb7cd7951e2581 Mon Sep 17 00:00:00 2001 From: Kevin Easton Date: Wed, 24 Apr 2013 12:05:44 +0000 Subject: [PATCH] Order the rfc1459[] array correctly. This is a longstanding bug - it's also present in EPIC4 and EPIC5 so it's probably been in BitchX since the beginning. The bug has been latent until the AUTHENTICATE and CAP commands were added, which perturbed the binary search so that the client didn't see invite messages properly. git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@235 13b04d17-f746-0410-82c6-800466cd88b0 --- Changelog | 2 ++ source/parse.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index 50676d0..87afc93 100644 --- a/Changelog +++ b/Changelog @@ -1,5 +1,7 @@ [Changes 1.2c01] +* Fix longstanding bug with ordering of rfc1459[] array. (caf) + * Fix crash after /SETAR -, reported by riderplus. (caf) * Remove special handling of 484 numeric, which is no longer needed and diff --git a/source/parse.c b/source/parse.c index 68d95cd..861aee9 100644 --- a/source/parse.c +++ b/source/parse.c @@ -1831,8 +1831,8 @@ protocol_command rfc1459[] = { { "CONNECT", NULL, NULL, 0, 0, 0}, { "ERROR", p_error, NULL, 0, 0, 0}, { "ERROR:", p_error, NULL, 0, 0, 0}, -{ "INVITE", p_invite, NULL, 0, 0, 0}, { "INFO", NULL, NULL, 0, 0, 0}, +{ "INVITE", p_invite, NULL, 0, 0, 0}, { "ISON", NULL, NULL, PROTO_NOQUOTE, 0, 0}, { "JOIN", p_channel, NULL, PROTO_DEPREC, 0, 0}, { "KICK", p_kick, NULL, 0, 0, 0}, @@ -1859,8 +1859,8 @@ protocol_command rfc1459[] = { { "STATS", NULL, NULL, 0, 0, 0}, { "SUMMON", NULL, NULL, 0, 0, 0}, { "TIME", NULL, NULL, 0, 0, 0}, -{ "TRACE", NULL, NULL, 0, 0, 0}, { "TOPIC", p_topic, NULL, 0, 0, 0}, +{ "TRACE", NULL, NULL, 0, 0, 0}, { "USER", NULL, NULL, 0, 0, 0}, { "USERHOST", NULL, NULL, PROTO_NOQUOTE, 0, 0}, { "USERS", NULL, NULL, 0, 0, 0},