Commit Graph

34 Commits

Author SHA1 Message Date
Kevin Easton
b1de392172 acro plugin: Don't sort scores when saving to file. This was losing the head
of the list, and it's not necessary anyway.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@264 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-10 12:57:06 +00:00
Tim Cava
ee35df3a41 Don't seed arcfour with uninitialized stack values when urandom can't be
opened, but fail instead. Fixes using uninitialized value warnings from
Coverity.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@263 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-09 07:06:43 +00:00
Tim Cava
e39eddbc04 Oops. Remove init_schat()'s forward declaration.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@262 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-09 06:54:57 +00:00
Tim Cava
ba8b5a67cb Kill unused initialization code in arcfour.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@261 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-09 06:39:50 +00:00
Tim Cava
0e099fe064 Kill unused code in dcc_sdcc() and eliminate an unused pointer value
warning from Coverity.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@260 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-08 04:42:46 +00:00
Tim Cava
b1e59bed9e Convert uses of new_malloc/strcpy in end_vote() to m_strdup. While I'm
here, don't cast what new_malloc returns.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@259 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-07 09:28:11 +00:00
Tim Cava
c76c962feb Convert uses of new_malloc/strcpy in take_vote() to m_strdup. While
I'm here, don't cast what new_malloc returns.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@258 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-07 09:22:04 +00:00
Tim Cava
e42c16a832 Convert uses of new_malloc/strcpy in take_acro() to m_strdup. While
I'm here, don't cast what new_malloc returns.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@257 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-07 09:17:02 +00:00
Tim Cava
5ab9f87936 Simplify show_acros() by sending each line immediately, rather than
buffering lines together.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@256 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-07 08:51:25 +00:00
Tim Cava
8a02a1946a Simplify show_scores() by sending each line immediately, rather than
buffering lines together. This also avoids a dereference before null
check found by Coverity.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@255 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-07 08:39:34 +00:00
Tim Cava
114f6f52f0 Reorder the members of struct _srec to make type punning with
Lists work.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@254 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-03 03:06:44 +00:00
Tim Cava
ed1ad22d70 Rewrite read_scores() with suggestions from caf. Failing to open the scores file no longer leaks memory, and a malformed record no longer adds an empty link to the global scores list.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@253 13b04d17-f746-0410-82c6-800466cd88b0
2013-07-02 14:42:36 +00:00
Tim Cava
c464efa90e Fix file descriptor leak in read_scores() found by Coverity.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@251 13b04d17-f746-0410-82c6-800466cd88b0
2013-06-28 07:34:06 +00:00
Tim Cava
ee761e7f02 Skip malformed entries in abots.sav, which avoids two null dereferences found by Coverity.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@250 13b04d17-f746-0410-82c6-800466cd88b0
2013-06-28 05:22:20 +00:00
Tim Cava
7a5448aa74 Don't make a copy of args, it goes unused. Remove the variable it was stored to. Found by Coverity.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@249 13b04d17-f746-0410-82c6-800466cd88b0
2013-06-26 13:09:01 +00:00
Tim Cava
3812cf36a6 Don't bother storing what get_window_by_name() returns, it goes unused. Found by Coverity.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@248 13b04d17-f746-0410-82c6-800466cd88b0
2013-06-26 11:51:41 +00:00
Kevin Easton
b5574f3b23 Replace fprintf() of single fixed buffer with fputs().
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@247 13b04d17-f746-0410-82c6-800466cd88b0
2013-06-25 12:16:38 +00:00
Kevin Easton
29a3747534 Fix sequence point issue in arcfour (S[x] = --x; is undefined).
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@228 13b04d17-f746-0410-82c6-800466cd88b0
2013-02-16 13:32:00 +00:00
Kevin Easton
da954a5c37 Apply patch from Dan Mashal (VICODAN) - Fix incorrect FSF address.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@225 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-17 12:55:55 +00:00
Kevin Easton
a1ec2113e9 Fix sort_scores in the acro plugin - pass the correct number of array entries
to qsort() and properly reconstruct the list.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@224 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-04 10:11:32 +00:00
Kevin Easton
f51de3a170 Fix the timer callbacks in the acro plugin to use the correct function
signature.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@223 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-04 09:03:12 +00:00
Kevin Easton
bf40ef7015 Use INSTALL_DATA instead of INSTALL to install the BitchX.hints file. This
means it's not made executable.

Patch from Jeff Horelick <jdhore@gentoo.org>.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@222 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-03 03:03:30 +00:00
Kevin Easton
84346beafa Make 'toc' target a dependency of aim.so, so that parallel building works.
Patch from Jeff Horelick <jdhore@gentoo.org>.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@221 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-03 02:57:39 +00:00
Kevin Easton
c3a2a39513 Don't strip plugins on install - it's no longer really necessary and helps in
debugging to have the symbols.

Patch from Jeff Horelick <jdhore@gentoo.org>.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@220 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-03 02:48:09 +00:00
Kevin Easton
69fd6e12c7 Change command used to install help files so that it ignores VCS directories.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@208 13b04d17-f746-0410-82c6-800466cd88b0
2012-06-17 23:22:55 +00:00
Kevin Easton
3bbe082f16 Fix aim and nap plugin Makefiles so that they build compat.o in the right
place when building out-of-tree.  Reported by nyet.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@166 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-08 15:20:39 +00:00
Kevin Easton
7ee26d4ed3 Change the install* targets in the Makefiles to honour DESTDIR. This
makes packaging the client for .deb and .rpm easier.

Reported separately by nyet and VICODAN.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@164 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-08 14:34:25 +00:00
Kevin Easton
2f92982eac Build script fix to allow plugins to build on x86-64.
$(SHLIB_CFLAGS) is required on the compile line, not just the link line.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@99 13b04d17-f746-0410-82c6-800466cd88b0
2010-09-09 01:08:14 +00:00
Kevin Easton
4decd6202b Fix snprintf buffer size.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@68 13b04d17-f746-0410-82c6-800466cd88b0
2009-09-08 13:40:45 +00:00
Kevin Easton
708e4b6f19 Change NICKSORT_OP to NICKSORT_STAT (sorts nicks by channel status -
chanop first, then halops, voices and others).  Added /SCAN -stat
to sort nicks using NICKSORT_OP.  Removed NICKSORT_VOICE - it was broken
anyway.

Removed "scan" plugin, this functionality is now covered by /SCAN -stat.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@52 13b04d17-f746-0410-82c6-800466cd88b0
2008-06-14 06:45:05 +00:00
Kevin Easton
d809649484 Merge r23 from branches/ircii-pana-1.1
Changes to allow compiling on gcc-4.0.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@40 13b04d17-f746-0410-82c6-800466cd88b0
2008-05-07 11:07:31 +00:00
Kevin Easton
3de93b1dbc Far-reaching changes to make BitchX compatible with 64 bit architectures
like x86-64, where sizeof(int) != sizeof (void *).  This involves correctly
casting every function pointer from the global table to the correct
function type, which has the added benefit of allowing type-checking of
function arguments and return values.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@26 13b04d17-f746-0410-82c6-800466cd88b0
2008-04-30 13:57:56 +00:00
Kevin Easton
533c3dbcbf Turn on SVN keyword replacement for $Date$, $Author$, $Revision$, $Id$ for all
*.c and *.h files.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/branches/ircii-pana-1.1@3 13b04d17-f746-0410-82c6-800466cd88b0
2008-02-25 09:49:14 +00:00
Kevin Easton
28febcfea9 Initial import of the ircii-pana-1.1-final source tree.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/tags/ircii-pana-1.1-final@1 13b04d17-f746-0410-82c6-800466cd88b0
2008-02-25 09:25:32 +00:00