Commit Graph

516 Commits

Author SHA1 Message Date
Kevin Easton
bad477f9dc Fix off-by-one error in the check for s against FD_SETSIZE in add_socketread()
and set_socketwrite().  This was found by Coverity.



git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@237 13b04d17-f746-0410-82c6-800466cd88b0
2013-06-16 06:04:29 +00:00
Kevin Easton
6045b8fe91 Fix installhelp target on OpenBSD.
The -R flag to cpio isn't portable, so replace it with an open-coded
shell loop.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@236 13b04d17-f746-0410-82c6-800466cd88b0
2013-05-22 11:56:20 +00:00
Kevin Easton
092d9789e0 Order the rfc1459[] array correctly.
This is a longstanding bug - it's also present in EPIC4 and EPIC5 so it's
probably been in BitchX since the beginning.  The bug has been latent until
the AUTHENTICATE and CAP commands were added, which perturbed the binary
search so that the client didn't see invite messages properly.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@235 13b04d17-f746-0410-82c6-800466cd88b0
2013-04-24 12:05:44 +00:00
Kevin Easton
73269ea887 Bail out of check_auto_reply() early if auto_str is NULL. This fixes a
crash after /SETAR -.

Reported by riderplus.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@234 13b04d17-f746-0410-82c6-800466cd88b0
2013-03-01 12:33:00 +00:00
Kevin Easton
17e3a91f03 Remove handling for the 484 numeric. It was intended for ircnet's 484
(ERR_RESTRICTED), to set user mode +r - however this does not appear to
be necessary anymore.  It was also buggy for several reasons: due to 
a change in set_server_flag() this has actually been setting mode +G; and
484 is ERR_ISCHANSERVICE on other ircds.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@233 13b04d17-f746-0410-82c6-800466cd88b0
2013-02-25 12:22:54 +00:00
Tim Cava
d7a0c781f8 Convert simple uses of alloca/strcpy to LOCAL_COPY.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@232 13b04d17-f746-0410-82c6-800466cd88b0
2013-02-24 07:32:59 +00:00
Tim Cava
a7c93a3950 Remove a redundant call to alloca.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@231 13b04d17-f746-0410-82c6-800466cd88b0
2013-02-23 20:57:24 +00:00
Kevin Easton
e99861dbfb Add /OBITS command showing obituaries for long-time BitchX friends.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@230 13b04d17-f746-0410-82c6-800466cd88b0
2013-02-21 22:29:34 +00:00
Kevin Easton
5da6c807c2 Remove old reference to BitchX.com
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@229 13b04d17-f746-0410-82c6-800466cd88b0
2013-02-21 11:04:35 +00:00
Kevin Easton
29a3747534 Fix sequence point issue in arcfour (S[x] = --x; is undefined).
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@228 13b04d17-f746-0410-82c6-800466cd88b0
2013-02-16 13:32:00 +00:00
Kevin Easton
1390402af1 Fix abuses of the RESIZE() macro in array.c, of the form:
x = RESIZE(x, type, size);

which should just be:

RESIZE(x, type, size);

The erroneous use is undefined behaviour according to the C standard, and
causes new versions of gcc (and, apparently, clang) to throw a warning.

Reported by nenolod/moogle.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@227 13b04d17-f746-0410-82c6-800466cd88b0
2013-02-16 08:11:07 +00:00
Kevin Easton
934d19aaa2 Some more minor BitchX.quit tidying.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@226 13b04d17-f746-0410-82c6-800466cd88b0
2013-02-16 08:06:20 +00:00
Kevin Easton
da954a5c37 Apply patch from Dan Mashal (VICODAN) - Fix incorrect FSF address.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@225 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-17 12:55:55 +00:00
Kevin Easton
a1ec2113e9 Fix sort_scores in the acro plugin - pass the correct number of array entries
to qsort() and properly reconstruct the list.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@224 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-04 10:11:32 +00:00
Kevin Easton
f51de3a170 Fix the timer callbacks in the acro plugin to use the correct function
signature.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@223 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-04 09:03:12 +00:00
Kevin Easton
bf40ef7015 Use INSTALL_DATA instead of INSTALL to install the BitchX.hints file. This
means it's not made executable.

Patch from Jeff Horelick <jdhore@gentoo.org>.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@222 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-03 03:03:30 +00:00
Kevin Easton
84346beafa Make 'toc' target a dependency of aim.so, so that parallel building works.
Patch from Jeff Horelick <jdhore@gentoo.org>.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@221 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-03 02:57:39 +00:00
Kevin Easton
c3a2a39513 Don't strip plugins on install - it's no longer really necessary and helps in
debugging to have the symbols.

Patch from Jeff Horelick <jdhore@gentoo.org>.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@220 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-03 02:48:09 +00:00
Kevin Easton
2027f75969 Move inclusion of system headers in misc.c to top, which fixes building on
recent Cygwin (including windows.h after the macros defined in modval.h
causes the build to fail due to our 'load' macro).  Reported by VICODAN.

Also define WIN32_LEAN_AND_MEAN in misc.c, which should speed up Cygwin
build times a little.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@219 13b04d17-f746-0410-82c6-800466cd88b0
2013-01-02 22:40:58 +00:00
Kevin Easton
754f1a19eb Update installation instructions, including changes from cpet.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@218 13b04d17-f746-0410-82c6-800466cd88b0
2012-12-31 13:27:29 +00:00
Kevin Easton
b2c9da8fef Fix the AC_CHECK_PLUGIN_SUPPORT configure macro so that it matches FreeBSD-1.*
instead of FreeBSD-1*, which fixes building with plugins on FreeBSD-10.  Also
a similar fix for the FreeBSD-2.* case.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@217 13b04d17-f746-0410-82c6-800466cd88b0
2012-12-30 22:47:03 +00:00
Kevin Easton
1541299fa1 Merge infrastructure for SASL authentication support from flashback.
This includes all of the underlying support, but doesn't hook it up to the
/SERVER command yet, so it's not useable at this point.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@216 13b04d17-f746-0410-82c6-800466cd88b0
2012-12-30 02:22:56 +00:00
Tim Cava
0d67cac5f7 Add a note about fixing QUITs with SSL connections.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@215 13b04d17-f746-0410-82c6-800466cd88b0
2012-10-21 01:36:23 +00:00
Kevin Easton
1e7c7edd1b Use LOG_PUBLIC instead of LOG_MSG for PRIVMSGs sent to channels.
This doesn't tend to affect what window they go to, since for channels
there's always a target window based on the channel.  But it does
affect logging.

This was fixed in EPIC4 back in 2001.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@214 13b04d17-f746-0410-82c6-800466cd88b0
2012-10-19 12:25:25 +00:00
Kevin Easton
f7607baf45 Add tcl.c to source distribution (panasync gave his permission for this to be released).
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@213 13b04d17-f746-0410-82c6-800466cd88b0
2012-10-19 12:11:05 +00:00
Tim Cava
416fcda578 Fix QUIT messages with SSL connections.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@212 13b04d17-f746-0410-82c6-800466cd88b0
2012-09-20 02:36:48 +00:00
Kevin Easton
c604db14e5 Add cp437 tool to contrib/ directory.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@211 13b04d17-f746-0410-82c6-800466cd88b0
2012-07-26 07:21:20 +00:00
Kevin Easton
18721ef0f2 Respin configure for configure.in r208.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@210 13b04d17-f746-0410-82c6-800466cd88b0
2012-06-17 23:30:20 +00:00
Kevin Easton
dd0c756cbc Add .deb package build files from nyet.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@209 13b04d17-f746-0410-82c6-800466cd88b0
2012-06-17 23:26:20 +00:00
Kevin Easton
69fd6e12c7 Change command used to install help files so that it ignores VCS directories.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@208 13b04d17-f746-0410-82c6-800466cd88b0
2012-06-17 23:22:55 +00:00
Kevin Easton
904ad9edef Update sites and mailing list addresses.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@207 13b04d17-f746-0410-82c6-800466cd88b0
2012-06-13 14:59:20 +00:00
Kevin Easton
d22a4531d8 Update old email addresses in user-visible messages.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@206 13b04d17-f746-0410-82c6-800466cd88b0
2012-06-13 12:34:32 +00:00
Tim Cava
46cf14c0da Fix the MKNU command, with suggestions from caf.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@205 13b04d17-f746-0410-82c6-800466cd88b0
2012-06-07 04:22:17 +00:00
Kevin Easton
3ed7f68d4e Rename include/bitchx to include/options.h. This fixes building on
case-insensitive filesystems like NTFS or HFS+, where it clashes with
the BitchX binary.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@204 13b04d17-f746-0410-82c6-800466cd88b0
2012-06-02 14:53:37 +00:00
Kevin Easton
252d1bf004 On systems that support it, supply the AI_ADDRCONFIG flag to getaddrinfo().
This means that we shouldn't try to connect using IPv6 if the local machine
doesn't have an IPv6 address itself.

This also simplifies the IPv6 code in BX_connect_by_number() a bit.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@203 13b04d17-f746-0410-82c6-800466cd88b0
2012-06-02 11:38:37 +00:00
Kevin Easton
64605b326c Respin configure for configure.in r201.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@202 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-31 12:43:57 +00:00
Kevin Easton
fa42be30ae Change configure.in to enable SSL by default, if libssl is present. Can
still be disabled with --without-ssl.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@201 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-31 12:40:26 +00:00
Kevin Easton
dd51b53e7d AC_CHECK_LIB() doesn't work to check for Windows API functions due to calling
conventions, so use AC_LINK_IFELSE() instead.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@200 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-30 12:26:44 +00:00
Kevin Easton
27c4333ef5 Respin configure and defs.h.in for configure.in r198.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@199 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-28 13:54:19 +00:00
Kevin Easton
d13eee6683 The Cygwin resolver library doesn't fill out the list of name servers in
res_init() if /etc/resolv.conf doesn't exist, which is usual.

Add code to handle this by calling GetNetworkParams().


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@198 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-28 13:52:18 +00:00
Kevin Easton
1c2581aea3 Respin configure for configure.in r196.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@197 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-27 04:43:40 +00:00
Kevin Easton
79625bf516 Define BIND_4_COMPAT everywhere (except OS X, who just _had_ to be different)
and switch to using BIND4 macros (GETSHORT / GETLONG).

Should fix /nslookup on OpenBSD.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@196 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-27 04:42:09 +00:00
Kevin Easton
82f7a2ccf2 Use AC_LANG_SOURCE() around argument to AC_LINK_IFELSE(), this means that we
get confdefs.h included in the test.

This should fix the resolver linking issue on OS X.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@195 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-27 04:26:36 +00:00
Kevin Easton
6947c0492d Update configure for configure.in r193.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@194 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-24 13:03:57 +00:00
Kevin Easton
8a9917270c Alter method of finding resolver library name, to hopefully work on OSX.
Now uses AC_LINK_IFELSE() to link a program that calls res_mkquery(),
after defining BIND_8_COMPAT / BIND_4_COMPAT as per misc.c.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@193 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-24 13:02:44 +00:00
Kevin Easton
241f3df842 Spin up new configure for configure.in r191.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@192 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-15 14:32:26 +00:00
Kevin Easton
5b7c84fb55 Rework res_mkquery test, adding test for __res_mkquery to fix problem on
x86-64 platforms reported by snadge.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@191 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-15 14:31:05 +00:00
Kevin Easton
43f5288dd4 Update document to remove old supported platforms list and correct old
information about vhosts.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@190 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-15 14:29:06 +00:00
Kevin Easton
ab7d59f1f6 Add a length sanity check - just in case there's an implementation out there
that parses AF_UNIX addresses in getaddrinfo() or something.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@189 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-15 14:01:42 +00:00
Kevin Easton
ba365bfd54 Fix logic error that can result in a potential crash (when getaddrinfo() fails
and res happened to be NULL).

Also add missing freeaddrinfo() call.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@188 13b04d17-f746-0410-82c6-800466cd88b0
2012-05-15 13:29:32 +00:00