Tim Cava
582d720ea4
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@460 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:29:21 +00:00
Tim Cava
496d3dc8ff
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@459 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:29:16 +00:00
Tim Cava
f69404b0f9
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@458 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:29:11 +00:00
Tim Cava
4f5aab355b
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@457 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:29:05 +00:00
Tim Cava
317b84ee9d
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@456 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:29:00 +00:00
Tim Cava
c9d059cee6
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@455 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:28:55 +00:00
Tim Cava
1bafc85e23
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@454 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:28:48 +00:00
Tim Cava
dd88392b15
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@453 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:28:38 +00:00
Tim Cava
3287f7775b
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@452 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:28:31 +00:00
Tim Cava
2677dc4c60
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@451 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:28:26 +00:00
Tim Cava
bfc147418a
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@450 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:28:19 +00:00
Tim Cava
9d7c4f93d0
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@449 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:28:10 +00:00
Tim Cava
c7e6e5ea08
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@448 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:28:03 +00:00
Tim Cava
c1530e9406
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@447 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:24:14 +00:00
Tim Cava
78265498b1
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@446 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:23:51 +00:00
Tim Cava
224143f653
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@445 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:23:25 +00:00
Tim Cava
db8c5cdc4f
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@444 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:22:00 +00:00
Tim Cava
6fed90327c
Convert sprintf calls to snprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@443 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 21:20:39 +00:00
Kevin Easton
d9a81a2841
who.c: Apply patch from tau replacing sprintf() with snprintf().
...
Also some minor associated cleanups from me.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@442 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 13:48:32 +00:00
Kevin Easton
220225f4ff
whowas.c: Apply patch from tau replacing sprintf() with snprintf().
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@441 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 13:37:14 +00:00
Kevin Easton
f222b94d13
window.c: Apply patch from tau replacing sprintf() with snprintf().
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@440 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 13:24:38 +00:00
Kevin Easton
f086f264bb
wserv.c: Apply patch from tau converting sprintf() to snprintf().
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@439 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-11 13:23:11 +00:00
Kevin Easton
03761ec715
Respin configure and defs.h.in for new configure.in, and update ircterm.h to match.
...
ircterm.h now includes ncurses/ncurses.h if present, which is necessary for Cygwin.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@438 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-10 12:00:08 +00:00
Kevin Easton
f2aa46e252
Add check for ncurses/ncurses.h to configure. This is where Cygwin installs ncurses.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@437 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-10 11:57:45 +00:00
Kevin Easton
ecabc12b3d
Add helper macros to always call tparm() with 10 arguments.
...
This ensures portability to systems with a fixed-argument list declaration
of tparm(), like NetBSD curses.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@436 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-10 06:27:03 +00:00
Kevin Easton
0fe37326a3
Rebuild configure and defs.h.in from new configure.in, and update code to match.
...
This simplifies the inclusion logic in ircterm.h, and updates term.c to include
term.h if available. This removes the declarations for setupterm(), tigetstr(),
tigetnum(), tigetflag(), tgetent(), tgetstr(), tgetnum() and tgetflag() from
term.c as those should be defined in term.h or termcap.h.
This should make the system declaration of tparm() available to term.c, which
will fix a crash on NetBSD x86-64 caused by the implicit declaration of tparm()
having a return type of 'int' while the real function has a return type of
'char *'.
We have to include term.h in term.c, not in ircterm.h because term.h defines
a large number of macros, at least two of which ('lines' and 'goto_window')
conflict with names in use in the rest of the codebase.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@435 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-10 05:38:06 +00:00
Kevin Easton
73c9947324
Rewrite the termcap/terminfo detection logic in configure.
...
The new logic is considerably shorter and simpler, and should mean that
terminfo is properly used in preference to termcap on NetBSD. This also
allows us to include term.h in term.c, where the system definition of
tparm() lives on some systems (NetBSD is one such).
The new logic also means we link against libtinfo in preference to
libncurses, which should mean a little less memory used at runtime and a
fraction faster startup time.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@434 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-10 04:50:52 +00:00
Kevin Easton
96f1d64aa0
Change ircterm.h header include guard so that it doesn't clash with
...
the system term.h.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@433 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-09 11:04:30 +00:00
Tim Cava
112b38ac7a
Revert the last commit. It accidentally had autogenerated files in it.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@432 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-07 03:00:24 +00:00
Tim Cava
276fd24258
Use snprintf rather than sprintf. From pvaldes.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@431 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-07 02:41:16 +00:00
Kevin Easton
590ae4c685
Further cleanups in dcc.c, removing unused variables and reworking dcc_exempt_save().
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@430 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-06 10:35:16 +00:00
Kevin Easton
15894eb006
Some simplification / cleanup in dcc_glist().
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@429 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-05 13:07:06 +00:00
Kevin Easton
456a0061f0
Fix output when client is built against termcap.
...
The pointer passed to tgetstr() must not be reset each time around the loop.
Also some other minor cleanups in term_init().
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@428 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-01 13:06:02 +00:00
Tim Cava
8e8a4022f9
Cleanup check_serverlag(), with suggestions from caf.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@427 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-01 11:32:57 +00:00
Kevin Easton
25dcf0709b
Don't crash if the user gives a bogus status format with too many elements.
...
Replace unused .format_var member of status_expandos list with .args. For
expandos which have a subformat, this stores how many arguments are passed to
sprintf() when the subformat is expanded in the callback function. The
convert_sub_format() function then uses this to limit the number of %s
conversion specifiers it creates in the converted subformat.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@426 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-30 13:09:03 +00:00
Kevin Easton
02327eebae
Fix STATUS_NOTIFY so that it appears in the right window.
...
The old code was reusing the 'window' variable, which means that it
could pick up the STATUS_NOTIFY format from the wrong window. You
would only have noticed this if you have windows with different settings
for STATUS_NOTIFY.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@425 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-29 13:25:10 +00:00
Kevin Easton
e9d180f526
Improve handling of padding in status formats.
...
Status formats support a %<PAD>c syntax for specifying padding. This change
ensures that we only use padding consisting of the characters "0123456789.",
which ensures it won't confuse sprintf.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@424 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-29 13:14:19 +00:00
Kevin Easton
e281537918
logfile should be initialised from LOGFILE_VAR if that is set.
...
We can also rearrange things to remove the need for the add_ext variable,
hopefully also making the logic a bit more clear.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@423 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-27 15:08:23 +00:00
Tim Cava
6094d62550
Cleanup window_help(). Use strlcat rather than strmcat.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@422 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 16:43:49 +00:00
Tim Cava
37f59831a2
Refactor window_log(). Use strlcat rather than strmcat. Rename a variable
...
and remove a buffer on the stack.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@421 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 15:30:09 +00:00
Tim Cava
9a5f10b8c5
Oops. nick must be initialized before old_uh, since it's passed to
...
fetch_userhost().
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@420 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 15:16:36 +00:00
Tim Cava
0cf0cf1ec4
Cleanup userhostbase. Use strlcat rather than strmcat. Rename some variables.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@419 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 15:03:12 +00:00
Tim Cava
9d562a6225
Cleanup convert_flags() a little bit.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@418 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 13:12:08 +00:00
Tim Cava
a0faae3e62
Cleanup convert_flags_to_str() a little bit. Use strlcat rather than strmcat.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@417 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 13:09:29 +00:00
Tim Cava
41dcaad142
Cleanup check_on_hook(). Use strlcat rather than strmcat. Don't
...
initialize variables unless necessary.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@416 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 02:54:04 +00:00
Tim Cava
1d1cd09ee3
Cleanup status_notify_windows() a little bit. Use strlcat rather than strmcat.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@415 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 02:43:57 +00:00
Tim Cava
e9ef2d4e55
Use strlcat, rather than strmcat, in make_status(). Remove a block of unused
...
ifdefed out code.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@414 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 02:34:25 +00:00
Tim Cava
fdb83238de
Cleanup stat_convert_format() a little bit. Use strlcat rather than strmcat.
...
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@413 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 02:28:13 +00:00
Tim Cava
26e070565e
Use strlcat, rather than strmcat, in fix_status_buffer(). Remove unused
...
blocks of ifdeffed out code.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@412 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 02:20:19 +00:00
Tim Cava
95235006ab
Cleanup convert_sub_format() a little bit. Use strlcat rather than strmcat.
...
Remove a variable that had no affect.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@411 13b04d17-f746-0410-82c6-800466cd88b0
2013-10-26 02:12:42 +00:00