Commit Graph

603 Commits

Author SHA1 Message Date
Kevin Easton
0b6725dbe2 Remove WANT_CHAN_NICK_SERV define and include services commands by default.
They're pretty widely used these days, and the cost is trivial.  And quite frankly,
the less #ifdefs I have to see, the better.

This covers /NICKSERV, /CHANSERV, /OPERSERV and /MEMOSERV.  It also brings 
in the bahamut / unreal /SILENCE server-side-ignore command, and unreal's /HELPOP.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@524 13b04d17-f746-0410-82c6-800466cd88b0
2014-11-04 10:27:19 +00:00
Kevin Easton
78aeaeb1cb Cleanups around WANT_CHAN_NICK.
Remove unused function declaration, add SERVERREQ flag to CHANSERV command and remove IRCIIHELP
command that no server has provided in a long time, as far as I can tell.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@523 13b04d17-f746-0410-82c6-800466cd88b0
2014-11-04 10:05:58 +00:00
Kevin Easton
eb5f767d53 Update default /FSET LINKS so it shows more than the first word of the server description.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@522 13b04d17-f746-0410-82c6-800466cd88b0
2014-11-03 10:32:21 +00:00
Kevin Easton
f6d42f35d4 Fix spelling mistake in client message.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@521 13b04d17-f746-0410-82c6-800466cd88b0
2014-11-03 10:26:13 +00:00
Kevin Easton
685fc8b25a bxconf has its own set of required libraries, different to the client itself.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@520 13b04d17-f746-0410-82c6-800466cd88b0
2014-11-01 14:52:43 +00:00
Kevin Easton
a05b1160c3 Change build to pass through CPPFLAGS if provided, and to use the DEFS value set by configure.
The DEFS Makefile variable has been renamed to CPPFLAGS, and is now set based on the CPPFLAGS,
INCLUDES and DEFS values provided by configure.

Reported by cpet, this allows the FreeBSD port to drop a patch.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@519 13b04d17-f746-0410-82c6-800466cd88b0
2014-11-01 14:37:41 +00:00
Kevin Easton
4ce8dc88de Update default server list.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@518 13b04d17-f746-0410-82c6-800466cd88b0
2014-11-01 11:13:47 +00:00
Kevin Easton
4f181b5977 Cleanup and update some ancilliary infomation files.
Bump copyright date, add TCL information to README-1.2, replace old COMPILE-PROBLEMS with more relevant
information and remove old 'bugs' file.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@517 13b04d17-f746-0410-82c6-800466cd88b0
2014-11-01 03:40:30 +00:00
Kevin Easton
f84d9c0b42 Add some more user-visible changes to the 1.2 README file.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@516 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-30 12:28:28 +00:00
Kevin Easton
db3fabfc3e Delay setting the /cset CHANMODE mode on new channels until the channel is synched.
Instead of setting the mode at NAMES time (when we know that the channel is new),
remember this for later by setting the GOTNEW flag in the joinlist entry.  Then
check this flag when the channel is synched.

Setting the channel mode takes us out of server "grace mode", which slows down the 
processing of subsequent commands and drastically reduces the number of commands we
can have outstanding before we get kicked off for flooding.  This change allows us
to stay in grace mode while we're synching every channel that we joined at connect.

In turn, this makes joining lots of channels on connect faster, and much less likely
to cause us to be booted with "Excess Flood".


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@515 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-29 14:07:05 +00:00
Kevin Easton
8054c3e4ab Rename show_channel_sync() to channel_sync(), and don't use prepare_command() before it.
prepare_command() does nothing useful here, and it sets the current server to an incorrect value
if the channel sync happens while the current window is set to a window from a different server.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@514 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-29 12:51:40 +00:00
Kevin Easton
3816ea7494 Don't execute an empty command for an empty branch in an /IF.
Old behaviour was that /if (0) { echo y } would execute an empty command for the missing else
case, which winds up doing send_text("").


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@513 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-27 12:05:16 +00:00
Kevin Easton
7563f1d401 Cache the bitmask of the channel log level in the cset structure instead of the channel structure.
This fixes a bug where the cached channel log level bitmask was not correctly set unless you did a 
/cset CHANNEL_LOG_LEVEL after the channel had been joined, which resulted in most things not being
logged.

It makes most sense to cache the bitmask within the cset structure, and there was even an (ununsed)
field already there for it.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@512 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-26 13:08:43 +00:00
Kevin Easton
34c34b9a43 Add ccTLDs for .cw (Curacao) and .sx (Sint Maarten).
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@511 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-21 12:21:24 +00:00
Kevin Easton
3f3bdf5387 Display user and channel mode changes at level MODEUSER and MODECHAN instead of CRAP.
These were already being logged at the correct level, this just fixes the
interaction with window level and window notify_level.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@510 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-18 13:18:13 +00:00
Kevin Easton
de1145ffc9 Refine illegal message source characters: * is in, - is out.
IRCNet uses message sources like *.se (ie masked server names) after a
netsplit.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@509 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-14 13:44:45 +00:00
Kevin Easton
c41048b896 Increase size of buffer to handle maximum-length topics in status_topic().
This affects the maximum length of the topic that can be displayed by the %-
status format.  No topic can be longer than IRCD_BUFFER_SIZE, so use that.

Reported by oxy.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@508 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-14 12:57:01 +00:00
Kevin Easton
8fde6f8248 Don't allow message source name to include ','.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@507 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-14 12:37:56 +00:00
Kevin Easton
5126d21126 Add /FSET WHOIS_LOGGEDIN to format RPL_WHOISLOGGEDIN, used by hybrid, ratbox, ircu and derivatives.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@506 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-10 12:56:09 +00:00
Kevin Easton
4d14d35d1a Allow nicknames to start with ~, apparently allowed by IRCnet.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@505 13b04d17-f746-0410-82c6-800466cd88b0
2014-10-05 22:19:39 +00:00
Kevin Easton
5e55fc5dee Cleanup send_whom(), and fix bug where get_socketinfo() was used instead of get_socket().
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@504 13b04d17-f746-0410-82c6-800466cd88b0
2014-09-24 14:28:19 +00:00
Kevin Easton
337c3128d1 Fix faulty boolean logic in .echo xlink command.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@503 13b04d17-f746-0410-82c6-800466cd88b0
2014-09-24 14:14:59 +00:00
Kevin Easton
6d2675e312 Slight cleanup to some xlink code.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@502 13b04d17-f746-0410-82c6-800466cd88b0
2014-09-24 13:35:13 +00:00
Kevin Easton
b99118c030 Add sanity checking of incoming nicknames.
Check that at least the first character of an incoming nickname is valid (we
actually go a bit beyond the RFC by also allowing any char with bit 8 set - at
least Russian servers use nicknames like this).


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@501 13b04d17-f746-0410-82c6-800466cd88b0
2014-09-24 06:54:00 +00:00
Kevin Easton
6dc2335df9 The /mv command shouldn't send +v for already-voiced users.
The logic in the massop function to exclude already-voiced users from
massvoice was faulty - it was equivalent to just !nick_isop().


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@500 13b04d17-f746-0410-82c6-800466cd88b0
2014-09-23 13:59:03 +00:00
Kevin Easton
a3170cf578 Fix regression introduced in r480, where /BKI on non-joined clients no longer ignored.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@499 13b04d17-f746-0410-82c6-800466cd88b0
2014-09-23 13:46:47 +00:00
Kevin Easton
e808dbe94b Change the lag check so that it does not try to format a time_t using %lu.
Recent OpenBSD and NetBSD have changed time_t to be a 64 bit type on all
platforms.  This means that on 32 bit systems, time_t is now longer than
long, and %lu can't be used to format it.

The lag check doesn't actually care what is in the first field of the PING
command, so change it to be our nick (which is arguably what it should be).


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@498 13b04d17-f746-0410-82c6-800466cd88b0
2014-09-21 14:54:12 +00:00
Tim Cava
72a20a8b82 Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@497 13b04d17-f746-0410-82c6-800466cd88b0
2014-03-02 21:25:49 +00:00
Tim Cava
b3cd3509d0 Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@496 13b04d17-f746-0410-82c6-800466cd88b0
2014-03-02 21:21:40 +00:00
Tim Cava
a266f0bad3 Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@495 13b04d17-f746-0410-82c6-800466cd88b0
2014-03-02 21:20:33 +00:00
Tim Cava
dd030f6e67 Make function_channelnicks() use the sort_type optionally passed in.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@494 13b04d17-f746-0410-82c6-800466cd88b0
2014-03-02 21:15:36 +00:00
Tim Cava
deb1c71b8c Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@493 13b04d17-f746-0410-82c6-800466cd88b0
2014-03-02 21:09:37 +00:00
Tim Cava
8d5882a9ef Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@492 13b04d17-f746-0410-82c6-800466cd88b0
2014-03-02 19:59:13 +00:00
Tim Cava
e7da953fc1 Don't check if the address of an array is NULL.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@491 13b04d17-f746-0410-82c6-800466cd88b0
2014-03-02 19:40:31 +00:00
Tim Cava
04e898bb57 Cleanup quotecmd() a little bit. Remove a set but unused variable.
Kill commented out code that normally prevents some commands from
being quoted.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@490 13b04d17-f746-0410-82c6-800466cd88b0
2014-03-01 20:02:16 +00:00
Tim Cava
3138017406 Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@489 13b04d17-f746-0410-82c6-800466cd88b0
2014-03-01 19:45:47 +00:00
Tim Cava
101204b0b9 Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@488 13b04d17-f746-0410-82c6-800466cd88b0
2014-03-01 19:44:55 +00:00
Tim Cava
ae4014808f Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@487 13b04d17-f746-0410-82c6-800466cd88b0
2014-02-28 23:52:33 +00:00
Tim Cava
7791aec8d6 Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@486 13b04d17-f746-0410-82c6-800466cd88b0
2014-02-28 23:47:14 +00:00
Tim Cava
c45a43c8e2 Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@485 13b04d17-f746-0410-82c6-800466cd88b0
2014-02-28 23:41:57 +00:00
Tim Cava
a9cc4ec891 Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@484 13b04d17-f746-0410-82c6-800466cd88b0
2014-02-28 23:39:57 +00:00
Tim Cava
ebc3ff9b2b Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@483 13b04d17-f746-0410-82c6-800466cd88b0
2014-02-28 23:31:58 +00:00
Tim Cava
3fe6a86f64 Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@482 13b04d17-f746-0410-82c6-800466cd88b0
2014-02-28 23:29:22 +00:00
Tim Cava
d8b8c169ab Remove a variable that is set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@481 13b04d17-f746-0410-82c6-800466cd88b0
2014-02-28 22:22:33 +00:00
Tim Cava
3494a55541 Remove variables that are set but unused.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@480 13b04d17-f746-0410-82c6-800466cd88b0
2014-02-28 22:13:49 +00:00
Kevin Easton
f13de53ad4 Fix bug introduced in r243 where /LASTLOG without -FILE no longer worked.
Reported by jeezy.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@479 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-24 13:15:22 +00:00
Kevin Easton
b300961524 alias.c: Remove unused variables in pmatch_cmd_alias(), pmatch_assign_alias() and do_stack_alias().
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@478 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-18 13:13:26 +00:00
Kevin Easton
f22dc54b13 Change BX_add_to_screen() and BX_skip_incoming_mirc() to use char * rather than unsigned char * arguments.
This clears up a few pointer type mismatch warnings.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@477 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-18 12:38:07 +00:00
Kevin Easton
ced7f9bcc9 keys.c: Convert most uses of unsigned char to char, clearing up warnings.
This also fixes the ability to bind to key sequences ending in ^.


git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@476 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-17 21:37:32 +00:00
Kevin Easton
de3d310678 Change RETURN_STR() macro to silence 'always evaluates to true' warnings.
git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@475 13b04d17-f746-0410-82c6-800466cd88b0
2013-11-16 11:35:41 +00:00