From e2b351b9ce3d7d0d5ce69f313120506346ba98c3 Mon Sep 17 00:00:00 2001 From: Kevin Easton Date: Fri, 30 Sep 2016 23:44:15 +1000 Subject: [PATCH] Remove unnecessary NULL checks in expr.c The first is unnecessary because after_expand() never returns NULL, and the 'rest' pointer has been dereferenced multiple times anyway. The second is unnecessary because parse_number(&ptr) cannot set ptr to NULL. --- source/expr.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/source/expr.c b/source/expr.c index e052e56..c640799 100644 --- a/source/expr.c +++ b/source/expr.c @@ -1703,8 +1703,7 @@ register unsigned char c; TruncateAndQuote(buffer, val, length, quote_em, pad_char); new_free(&val); new_free(&sub_buffer); - if (rest) - *rest = c2; + *rest = c2; return rest; } @@ -1789,7 +1788,7 @@ register unsigned char c; TruncateAndQuote(buffer, tmp2, length, quote_em, pad_char); new_free(&tmp2); - return (ptr ? ptr : empty_string); + return ptr; } /*