From caba4c830caff047466cbe81698ceb9f95ca9429 Mon Sep 17 00:00:00 2001 From: Kevin Easton Date: Fri, 21 Oct 2016 00:47:51 +1100 Subject: [PATCH] Length-check copies to DCC_current_transfer_buffer --- source/dcc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/source/dcc.c b/source/dcc.c index 52759d6..5adf714 100644 --- a/source/dcc.c +++ b/source/dcc.c @@ -2891,11 +2891,14 @@ register int i = 0; /* chop(transfer_buffer, 1);*/ if (fget_string_var(FORMAT_DCC_FSET)) { - sprintf(DCC_current_transfer_buffer, "%s", convert_output_format(fget_string_var(FORMAT_DCC_FSET), "%s", transfer_buffer)); + strlcpy(DCC_current_transfer_buffer, + convert_output_format(fget_string_var(FORMAT_DCC_FSET), "%s", transfer_buffer), + sizeof DCC_current_transfer_buffer); chop(DCC_current_transfer_buffer, 4); } else - sprintf(DCC_current_transfer_buffer, "[%s]", transfer_buffer); + snprintf(DCC_current_transfer_buffer, sizeof DCC_current_transfer_buffer, + "[%s]", transfer_buffer); } else *DCC_current_transfer_buffer = 0;