From 2fc84d5f93991269c0922f24a1193289a9107363 Mon Sep 17 00:00:00 2001 From: Kevin Easton Date: Tue, 18 Jun 2013 11:00:12 +0000 Subject: [PATCH] Fix a file descriptor leak when connect() fails during a SOCKS4 proxy connection attempt. git-svn-id: svn://svn.code.sf.net/p/bitchx/code/trunk@242 13b04d17-f746-0410-82c6-800466cd88b0 --- Changelog | 3 +++ source/network.c | 1 + 2 files changed, 4 insertions(+) diff --git a/Changelog b/Changelog index c140191..e00e12b 100644 --- a/Changelog +++ b/Changelog @@ -1,5 +1,8 @@ [Changes 1.2c01] +* Fix file descriptor leak on SOCKS4 connection failure found by + Coverity. (caf) + * Fix out-of-bounds error in cryptit() found by Coverity. (flashback) * Cleanup save_formats(). (caf) diff --git a/source/network.c b/source/network.c index e71b024..bc07129 100644 --- a/source/network.c +++ b/source/network.c @@ -343,6 +343,7 @@ int handle_socks(int fd, struct sockaddr_in addr, char *host, int portnum) { alarm(0); bitchsay("Unable to connect to SOCKS4 proxy: %s", strerror(errno)); + close(fd); return -1; } alarm(0);