philippelh/bitchx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix typo testing VIF_CHANGED

Browse Source 
This error seemed to be benign, because I don't think there was a way to get here with
int_flags non-zero without VIF_CHANGED already set.

Remove unnecessary tests for 'value' and '!value', because value is always non-NULL in that
code path.
This commit is contained in:
Kevin Easton
2017-10-27 20:35:33 +11:00
parent a220b8aa7f
commit 1cb3775ced
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
source/vars.c
View File

@@ -935,11 +935,9 @@ void set_var_value(int var_index, char *value, IrcVariableDll *dll)
else else
say("SET: no such user"); say("SET: no such user");
} }
if ((!var->int_flags & VIF_CHANGED)) if (!(var->int_flags & VIF_CHANGED))
{ {
if ((var->string && ! value) || if (!var->string || my_stricmp(var->string, value))
(! var->string && value) ||
my_stricmp(var->string, value))
var->int_flags |= VIF_CHANGED; var->int_flags |= VIF_CHANGED;
} }
if (loading_global) if (loading_global)